thumbnail_test.go 4.3 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126
  1. package storage
  2. import (
  3. "bytes"
  4. "context"
  5. "errors"
  6. "os"
  7. "path/filepath"
  8. "sync/atomic"
  9. "testing"
  10. "time"
  11. "imuslab.com/arozos/mod/filesystem/arozfs"
  12. )
  13. // countingRenderer renders "thumb:<file name>" and counts its calls. Files
  14. // named none.* have no thumbnail.
  15. func countingRenderer(calls *int32) func(string) ([]byte, error) {
  16. return func(osPath string) ([]byte, error) {
  17. atomic.AddInt32(calls, 1)
  18. if _, err := os.Stat(osPath); err != nil {
  19. return nil, err
  20. }
  21. name := filepath.Base(osPath)
  22. if name == "none.png" {
  23. return nil, arozfs.ErrNoThumbnail
  24. }
  25. return []byte("thumb:" + name), nil
  26. }
  27. }
  28. func TestThumbnailRenderedByHolder(t *testing.T) {
  29. a, b := cluster2(t)
  30. var aCalls, bCalls int32
  31. a.thumb.Store(countingRenderer(&aCalls))
  32. b.thumb.Store(countingRenderer(&bCalls))
  33. for _, p := range []string{"/pics/a.png", "/pics/none.png"} {
  34. if err := a.svc.Write(p, bytes.NewReader([]byte("image")), ""); err != nil {
  35. t.Fatalf("write %s: %v", p, err)
  36. }
  37. }
  38. if err := a.svc.Mkdir("/pics/sub", ""); err != nil {
  39. t.Fatalf("mkdir: %v", err)
  40. }
  41. waitFor(t, "b to see the files", 5*time.Second, func() bool {
  42. _, err := b.meta.Stat("/pics/none.png")
  43. return err == nil
  44. })
  45. ctx, cancel := context.WithTimeout(context.Background(), 20*time.Second)
  46. defer cancel()
  47. testcases := []struct {
  48. name string
  49. node *testNode
  50. path string
  51. want string
  52. wantErr error
  53. aRenders int32
  54. bRenders int32
  55. }{
  56. //The holder renders its own copy without any request
  57. {name: "local copy", node: a, path: "/pics/a.png", want: "thumb:a.png", aRenders: 1},
  58. //b holds no copy: a renders it and only the image comes back
  59. {name: "remote copy", node: b, path: "/pics/a.png", want: "thumb:a.png", aRenders: 2},
  60. //No thumbnail is an answer about the content and comes back as such
  61. {name: "no thumbnail remote", node: b, path: "/pics/none.png", wantErr: arozfs.ErrNoThumbnail, aRenders: 3},
  62. {name: "no thumbnail local", node: a, path: "/pics/none.png", wantErr: arozfs.ErrNoThumbnail, aRenders: 4},
  63. //Folders and missing files never reach a renderer
  64. {name: "folder", node: b, path: "/pics/sub", wantErr: arozfs.ErrNoThumbnail, aRenders: 4},
  65. {name: "missing", node: b, path: "/pics/missing.png", wantErr: os.ErrNotExist, aRenders: 4},
  66. }
  67. for _, tc := range testcases {
  68. data, err := tc.node.svc.Thumbnail(ctx, tc.path, "")
  69. if tc.wantErr != nil {
  70. if !errors.Is(err, tc.wantErr) {
  71. t.Errorf("%s: expected %v, got %v (%q)", tc.name, tc.wantErr, err, data)
  72. }
  73. } else if err != nil || string(data) != tc.want {
  74. t.Errorf("%s: got %q, %v; wanted %q", tc.name, data, err, tc.want)
  75. }
  76. if got := atomic.LoadInt32(&aCalls); got != tc.aRenders {
  77. t.Errorf("%s: a rendered %d times in total, wanted %d", tc.name, got, tc.aRenders)
  78. }
  79. if got := atomic.LoadInt32(&bCalls); got != tc.bRenders {
  80. t.Errorf("%s: b rendered %d times in total, wanted %d", tc.name, got, tc.bRenders)
  81. }
  82. }
  83. }
  84. func TestThumbnailHolderLimits(t *testing.T) {
  85. a, b := cluster2(t)
  86. if err := a.svc.Write("/v/clip.mp4", bytes.NewReader([]byte("video")), ""); err != nil {
  87. t.Fatalf("write: %v", err)
  88. }
  89. waitFor(t, "b to see the file", 5*time.Second, func() bool {
  90. _, err := b.meta.Stat("/v/clip.mp4")
  91. return err == nil
  92. })
  93. ctx, cancel := context.WithTimeout(context.Background(), 20*time.Second)
  94. defer cancel()
  95. //The only holder has no renderer: a failure, but not "no thumbnail",
  96. //since another node could still render it later
  97. _, err := b.svc.Thumbnail(ctx, "/v/clip.mp4", "")
  98. if err == nil || errors.Is(err, arozfs.ErrNoThumbnail) {
  99. t.Errorf("a holder without a renderer should fail with a retryable error, got %v", err)
  100. }
  101. //A holder that lacks the tool the format needs is not asked at all
  102. var calls int32
  103. a.thumb.Store(countingRenderer(&calls))
  104. if _, err := b.svc.Thumbnail(ctx, "/v/clip.mp4", "no-such-feature"); !errors.Is(err, ErrNoThumbnailHolder) {
  105. t.Errorf("expected ErrNoThumbnailHolder, got %v", err)
  106. }
  107. if atomic.LoadInt32(&calls) != 0 {
  108. t.Errorf("a holder without the feature was asked to render")
  109. }
  110. //An oversized thumbnail is refused rather than passed on
  111. a.thumb.Store(func(string) ([]byte, error) { return make([]byte, MaxThumbnailBytes+1), nil })
  112. if _, err := a.svc.Thumbnail(ctx, "/v/clip.mp4", ""); err == nil {
  113. t.Error("an oversized thumbnail should be refused")
  114. }
  115. }